Set initial sim time from the command-line #3294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Audrow Nash <audrow.j.nash@nasa.gov>
Signed-off-by: Audrow Nash <audrow.j.nash@nasa.gov>
I didn't realize that our |
scpeters
reviewed
Feb 1, 2023
gazebo/Server.cc
Outdated
| @@ -194,6 +194,8 @@ bool Server::ParseArgs(int _argc, char **_argv) | |||
| "Absolute path in which to store state data") | |||
| ("record_period", po::value<double>()->default_value(-1), | |||
| "Recording period (seconds).") | |||
| ("initial_sim_time", po::value<double>(), | |||
| "Initial simulation time (seconds).") | |||
There was a problem hiding this comment.
I believe the order of these arguments determines the formatting of the help string, so I would move this out of the middle of the record_* arguments to be next to iters
There was a problem hiding this comment.
thanks; I pushed it one more line in 7f872b4
Signed-off-by: Audrow Nash <audrow.j.nash@nasa.gov>
Signed-off-by: Audrow Nash <audrow.j.nash@nasa.gov>
Signed-off-by: Audrow Nash <audrow.j.nash@nasa.gov>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
scpeters
approved these changes
Feb 1, 2023
scpeters
added a commit
to ros-simulation/gazebo_ros_pkgs
that referenced
this pull request
Mar 1, 2023
Expose gzserver CLI parameter added in gazebosim/gazebo-classic#3294. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
scpeters
added a commit
to ros-simulation/gazebo_ros_pkgs
that referenced
this pull request
Mar 2, 2023
Expose gzserver CLI parameter added in gazebosim/gazebo-classic#3294. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
scpeters
added a commit
to ros-simulation/gazebo_ros_pkgs
that referenced
this pull request
Mar 3, 2023
Expose gzserver CLI parameter added in gazebosim/gazebo-classic#3294. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
scpeters
added a commit
to ros-simulation/gazebo_ros_pkgs
that referenced
this pull request
Mar 3, 2023
Expose gzserver CLI parameter added in gazebosim/gazebo-classic#3294. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
|
Shouldn't this PR also adjust the time that is set in gazebo-classic/gazebo/physics/World.cc Line 1456 in 17e09f5 |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
--initial_sim_timeflag togzserver. If the flag and a value is not provided, the behavior is not changed. This works with large times, such as epoch time and floating point numbers (see the test).FYI @scpeters